User talk:Sirtheta

Welcome to CrawlWiki! If you need help getting started, please visit the help section and how to help,

If you are looking for something to do, check out the Current projects page.

If you have any questions about this wiki you can talk to other editors here. Just remember to sign those posts with four tildes: ~~~~ (or click the signature button).

Unrand weapon types

I noticed you've been changing the listed weapon types of certain unrands (Autumn Katana, dark maul, etc.) while adding links to their source code (which is very helpful, by the way -- keep up the good work!). While I understand your reasoning behind the changes (the dark maul's code does indeed list it as OBJ_WEAPONS/WPN_GREAT_MACE), I feel that labeling it a great mace is incomplete and slightly misleading.

Special-cased unrands use regular weapon types as a baseline, but alter their stats to create what is essentially a new type of weapon -- in some cases, the only thing that remains the same is whether it's one-handed or two-handed. Additionally, their in-game descriptions list them as being a separate type of weapon entirely rather than a modified version of an existing one (the dark maul, as a continuing example, is listed as a maul in-game rather than a great mace, and does not show up in the results if you search for great maces).

I would instead list these weapons as the types in their in-game descriptions, possibly with a note regarding their original base weapon. For example:

the +10 dark maul

+10 maul (modified great mace; 52 base damage, -2 base accuracy, 30 base delay, two-handed)

What's your opinion on this subject? --spudwalt (talk) 20:54, 24 May 2019 (CEST)