Difference between revisions of "Module talk:Table of spells"
LunaeLumen (talk | contribs) (Looks good now. Poke me with a stick if something's still broken.) |
(how to generate) |
||
Line 5: | Line 5: | ||
:Right, it looks like it was the <code>format_noise</code> method, which was trying to find <code>math.max(noise.casting, noise.effect)</code> in [[Module:Spell]]. Switched to grabbing the first consecutive block of digits instead, and it seems to be working now. -[[User:LunaeLumen|LunaeLumen]] ([[User talk:LunaeLumen|talk]]) 21:57, 14 September 2020 (CEST) | :Right, it looks like it was the <code>format_noise</code> method, which was trying to find <code>math.max(noise.casting, noise.effect)</code> in [[Module:Spell]]. Switched to grabbing the first consecutive block of digits instead, and it seems to be working now. -[[User:LunaeLumen|LunaeLumen]] ([[User talk:LunaeLumen|talk]]) 21:57, 14 September 2020 (CEST) | ||
+ | |||
+ | ==Generating== | ||
+ | Currently the data is from [[0.25]], so we need to update it to [[0.28]]. To do this, https://github.com/plampila/crawl-wiki-modules speaks of a tool to generate a data table. It looks like the tool consists of the files changed at this [https://github.com/plampila/crawl/commit/1429969f80af867dfcc5431dd3ce1f7b4aae869f#diff-756f39d746a592012749140a642b24a8aa0e7f0df464c8f77a6a1edf68f50755|this commit]. So I'm thinking the process is to download the crawl 0.28 source code, make these file changes and then build and run <code>json-data-main.exe</code>. | ||
+ | |||
+ | One misleading thing is that [[Ice Magic]] for example says the page is for [[0.21]], but the data is from [[0.25]], so it seems like it should say that instead. Maybe the destination pages could use a different header template that reads: "The spell information is from 0.25 and may not be up to date for the latest stable release of Crawl" where the version number is read from this module. | ||
+ | --[[User:ScriptFactory|ScriptFactory]] ([[User talk:ScriptFactory|talk]]) 21:14, 8 February 2022 (CET) |
Revision as of 21:14, 8 February 2022
Spell Noise script error
I don't know much about using Modules, but as far as I can tell, some templates aren't prepared to accept full text in the Spell Effect Noise field (I dunno if they only accept integers or what). For the most part, this isn't a problem, but Inner Flame and Fulminant Prism both have an initial effect noise of 0 and then make more noise afterwards when their target explodes.
Ge0ff's last edit to this module worked well on Inner Flame's page, but (from what I can tell) broke everything based off of Template:spell table (so also things like Template:spell table by level, Template:spell table by school, Template:spell table by flag, etc.). Given that Template:spell info worked normally, I think the problem lies with those other templates. In any case, I went back to using the old spell template on the Inner Flame page so we at least have accurate information without breaking a whole bunch of spell lists.
Does anybody with more experience in coding wiki Module/Template relationships have a solution for this problem? --spudwalt (talk) 04:18, 14 September 2020 (CEST)
- Right, it looks like it was the
format_noise
method, which was trying to findmath.max(noise.casting, noise.effect)
in Module:Spell. Switched to grabbing the first consecutive block of digits instead, and it seems to be working now. -LunaeLumen (talk) 21:57, 14 September 2020 (CEST)
Generating
Currently the data is from 0.25, so we need to update it to 0.28. To do this, https://github.com/plampila/crawl-wiki-modules speaks of a tool to generate a data table. It looks like the tool consists of the files changed at this commit. So I'm thinking the process is to download the crawl 0.28 source code, make these file changes and then build and run json-data-main.exe
.
One misleading thing is that Ice Magic for example says the page is for 0.21, but the data is from 0.25, so it seems like it should say that instead. Maybe the destination pages could use a different header template that reads: "The spell information is from 0.25 and may not be up to date for the latest stable release of Crawl" where the version number is read from this module. --ScriptFactory (talk) 21:14, 8 February 2022 (CET)